SilverLining API Change

classic Classic list List threaded Threaded
4 messages Options
ravidavi ravidavi
Reply | Threaded
Open this post in threaded view
|

SilverLining API Change

Hi all,

SilverLining 5.079 (from Sep 28, 2020) made an API change in which CloudLayerFactor::Create() now takes two arguments (previously it took one). This means that the osgEarth SilverLining integration now has a few build errors.

Additionally, the FindSilverLining.cmake module explicitly searches the default SilverLining install location (C:\SilverLining SDK) and osgEarth has no way of disabling its SilverLining component in CMake. This breaks the build on machines that have SilverLining installed at the default location of "C:\SilverLining SDK".

Do any of you see this?

Thanks,
Ravi
gwaldron gwaldron
Reply | Threaded
Open this post in threaded view
|

Re: SilverLining API Change

Ravi,

Thanks for pointing this out. We will update and incorporate the fix into 3.1.

Hope you are doing well!
Glenn Waldron / Pelican Mapping
gwaldron gwaldron
Reply | Threaded
Open this post in threaded view
|

Re: SilverLining API Change

This is pushed to the 3.1 branch.
Glenn Waldron / Pelican Mapping
ravidavi ravidavi
Reply | Threaded
Open this post in threaded view
|

Re: SilverLining API Change

Thanks for the quick turnaround Glenn.

Congrats on the 3.1 release, and I hope you guys have a relaxing holiday season!

Ravi