Small Request with tinyxml

classic Classic list List threaded Threaded
5 messages Options
DC DC
Reply | Threaded
Open this post in threaded view
|

Small Request with tinyxml

Howdy,

Can you namespace your tinyxml?

I've run into several occassions where loading .earth files will use some of osgEarth's
tinyxml funtions, then runs off and uses another applications tinyxml of a different version; causing failure.

My most recent failure was from running osgEarth out of CodeXL. I hacked a namespace around your tinyxml and
it no longer crashed. I had to namespace our applications tinyxml to prevent this from happening on our side some time ago.

Thanks,

Chris
jasonbeverage jasonbeverage
Reply | Threaded
Open this post in threaded view
|

Re: Small Request with tinyxml

Can you send us a PR for this and we'll take a look at merging it?

Thanks!

Jason

On Fri, Oct 6, 2017 at 10:31 AM DC [via osgEarth] <[hidden email]> wrote:
Howdy,

Can you namespace your tinyxml?

I've run into several occassions where loading .earth files will use some of osgEarth's
tinyxml funtions, then runs off and uses another applications tinyxml of a different version; causing failure.

My most recent failure was from running osgEarth out of CodeXL. I hacked a namespace around your tinyxml and
it no longer crashed. I had to namespace our applications tinyxml to prevent this from happening on our side some time ago.

Thanks,

Chris


If you reply to this email, your message will be added to the discussion below:
http://forum.osgearth.org/Small-Request-with-tinyxml-tp7591261.html
To start a new topic under osgEarth, email [hidden email]
To unsubscribe from osgEarth, click here.
NAML
DC DC
Reply | Threaded
Open this post in threaded view
|

Re: Small Request with tinyxml

FYI,

If I did it correctly, the PR was sent 17 days ago.
jasonbeverage jasonbeverage
Reply | Threaded
Open this post in threaded view
|

Re: Small Request with tinyxml

Thanks for that, we still haven't had a chance to look at it yet.   I'll try to review it next week. 


On Fri, Oct 27, 2017, 11:56 AM DC [via osgEarth] <[hidden email]> wrote:
FYI,

If I did it correctly, the PR was sent 17 days ago.


If you reply to this email, your message will be added to the discussion below:
To start a new topic under osgEarth, email [hidden email]
To unsubscribe from osgEarth, click here.
NAML
jasonbeverage jasonbeverage
Reply | Threaded
Open this post in threaded view
|

Re: Small Request with tinyxml

In reply to this post by DC

Ah sorry, just saw where Glenn merged this :)


On Fri, Oct 27, 2017, 5:14 PM Jason Beverage <[hidden email]> wrote:

Thanks for that, we still haven't had a chance to look at it yet.   I'll try to review it next week. 


On Fri, Oct 27, 2017, 11:56 AM DC [via osgEarth] <[hidden email]> wrote:
FYI,

If I did it correctly, the PR was sent 17 days ago.


If you reply to this email, your message will be added to the discussion below:
To start a new topic under osgEarth, email [hidden email]
To unsubscribe from osgEarth, click here.
NAML